1
Fork 0

Add commits dropdown in PR files view and allow commit by commit review (#25528)

This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.

This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.

## Screenshots

### The commit dropdown

![image](0db3ae62-1272-436c-be64-4730c5d611e3)

### Selecting a commit range

![image](ad81eedb-8437-42b0-8073-2d940c25fe8f)

### Show changes of a single commit only

![image](6b1a113b-73ef-4ecc-adf6-bc2340bb8f97)

### Show changes of a commit range

![image](6401b358-cd66-4c09-8baa-6cf6177f23a7)


Fixes https://github.com/go-gitea/gitea/issues/20989
Fixes https://github.com/go-gitea/gitea/issues/19263

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
This commit is contained in:
sebastian-sauer 2023-07-28 21:18:12 +02:00 committed by GitHub
parent 4971a10543
commit 55532061c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
71 changed files with 748 additions and 35 deletions

View file

@ -0,0 +1 @@
ref: refs/heads/main

View file

@ -0,0 +1,4 @@
[core]
repositoryformatversion = 0
filemode = true
bare = true

View file

@ -0,0 +1 @@
Unnamed repository; edit this file 'description' to name the repository.

View file

@ -0,0 +1,6 @@
# git ls-files --others --exclude-from=.git/info/exclude
# Lines that start with '#' are comments.
# For a project mostly in C, the following would be a good set of
# exclude patterns (uncomment them if you want to use them):
# *.[oa]
# *~

View file

@ -0,0 +1,3 @@
1978192d98bb1b65e11c2cf37da854fbf94bffd6 refs/heads/branch1
cbff181af4c9c7fee3cf6c106699e07d9a3f54e6 refs/heads/main
1978192d98bb1b65e11c2cf37da854fbf94bffd6 refs/pull/1/head

View file

@ -0,0 +1 @@
0000000000000000000000000000000000000000 cbff181af4c9c7fee3cf6c106699e07d9a3f54e6 Gitea <gitea@fake.local> 1688672318 +0200

View file

@ -0,0 +1 @@
0000000000000000000000000000000000000000 1978192d98bb1b65e11c2cf37da854fbf94bffd6 Gitea <gitea@fake.local> 1688672383 +0200 push

View file

@ -0,0 +1 @@
0000000000000000000000000000000000000000 cbff181af4c9c7fee3cf6c106699e07d9a3f54e6 root <sauer.sebastian@gmail.com> 1688672317 +0200 push

View file

@ -0,0 +1,2 @@
x¥ŽA
Â0E]ç³$™´™D¼ƒ'˜If´`­´éý­ OàêÁƒ÷ùež¦±váÐUˆC©\Q;_ò<5F>™…%VÏHÆæ<C386>DS Ú»7/újPú„ÉJV³žT å$>Ô®zCFoí1/pSáµ<C3A1>üoºÀyýâ´þôõ>ñø<•yº@HÃ<48>#E8zôÞív?Ûöì¯×tmйJÝNê

View file

@ -0,0 +1,2 @@
x¥<>M
ֲ0F]ח³ֺה§<D794> ˆx‡<78>`ׂL´`­´י<D799> Oאךƒ<07>דMכ²ּ\°§÷©c;₪R²`<60>°8Oװ«„₪<E2809E>bVִ<56>gפז-›¾*LװXך)<06>q9זּ>ה>‘÷ֲ<05>"9ךc<D79A>`װ${<7B>ו£÷ֱe<D6B1><4E>נם¾ָ<C2BE>ל¦u¹˜j ־טM£-¶¶<C2B6>_Su¯@ז¼DLג

View file

@ -0,0 +1,3 @@
x¥ŽA
Â0E]ç³ÊL'MRñ=Á$™hÁZiÓûžÀՇǟŸÖe™+ôNuS…àSNÄÌe(D^ƾpÒâƒFEF"²‘¡y˦¯
Þúœ#èÄA+¾‘€­>8QreÔ9'#G}¬Le¯³¼`C7¸ìßèö¾Ý™Ÿ]Z—+<2B> Áùž=Ã{DÓh;[ö׌©ºWÍȵM

View file

@ -0,0 +1,2 @@
x+)JMU067`040031QrutńuŐËMa¸ďšĎ!Ľ´E~óÓŹGŠYM…**I-.1Ô+©(axsóď­<C48F>F‡Đw‰S…îŘ%˝gS"#°"ˬ€Ů)ýôBSć
p·˝Ř™sŕ)"c°˘KáS÷ďö°Ě¬köžZxÂv¦?"°˘é<±ŻKŐf؇ú­Z¸u"ÓĺÇľ#)2+2ý`'ž÷ěOŰÖ3ËfEs/Z †¤Č ¬¨Y×ř‰ĹĄ-+ňw5žN߬+¸Bă4"s°˘ŕY*Ťę¬ßKZÂú˛®ßn)ód><3E>¤Č¬<>łLѲDĎx,9]K*ô<> "K°"<22>Yěđăč­»óAÂ|ŞÄɉźZvŰ“G

View file

@ -0,0 +1,2 @@
xĄŽA
Â0E]çłĘ4I3ń=Á$L´`¬4éý­ OŕęÁ<C499>÷ůy­ué`ýxę*°%L<>AEÂT˛F‹Łě)bˇŔČć-›ľ:pČZĽP"ťGŃP0—ivĘH”ŮŮűcÝ`Ö$­YvÝŕŇľÚOßîUç<E28093>×z…1ÄČ:rpFh{śíGö׌éÚ:8ó•ELÇ

View file

@ -0,0 +1 @@
1978192d98bb1b65e11c2cf37da854fbf94bffd6

View file

@ -0,0 +1 @@
cbff181af4c9c7fee3cf6c106699e07d9a3f54e6

View file

@ -0,0 +1 @@
cbff181af4c9c7fee3cf6c106699e07d9a3f54e6

View file

@ -0,0 +1 @@
1978192d98bb1b65e11c2cf37da854fbf94bffd6