bjoernager/forgejo
bjoernager/forgejo
1
Fork 0
Code Activity

Add testifylint to lint checks (#4535)

Browse source 
go-require lint is ignored for now

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4535
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Co-committed-by: TheFox0x7 <thefox0x7@gmail.com>
This commit is contained in:
TheFox0x7 2024-07-30 19:41:10 +00:00 • committed by Earl Warren
parent 94933470cd
commit 4de909747b
504 changed files with 5028 additions and 4680 deletions
Download patch file Download diff file Expand all files Collapse all files

43
tests/integration/actions_trigger_test.go
View file

@ -31,6 +31,7 @@ import (
files_service "code.gitea.io/gitea/services/repository/files"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestPullRequestTargetEvent(t *testing.T) {
@ -50,7 +51,7 @@ func TestPullRequestTargetEvent(t *testing.T) {
Name: "forked-repo-pull-request-target",
Description: "test pull-request-target event",
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, forkedRepo)
// add workflow file to the base repo
@ -78,7 +79,7 @@ func TestPullRequestTargetEvent(t *testing.T) {
Committer: time.Now(),
},
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, addWorkflowToBaseResp)
// add a new file to the forked repo
@ -106,7 +107,7 @@ func TestPullRequestTargetEvent(t *testing.T) {
Committer: time.Now(),
},
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, addFileToForkedResp)
// create Pull
@ -127,7 +128,7 @@ func TestPullRequestTargetEvent(t *testing.T) {
Type: issues_model.PullRequestGitea,
}
err = pull_service.NewPullRequest(git.DefaultContext, baseRepo, pullIssue, nil, nil, pullRequest, nil)
assert.NoError(t, err)
require.NoError(t, err)
// if a PR "synchronized" event races the "opened" event by having the same SHA, it must be skipped. See https://codeberg.org/forgejo/forgejo/issues/2009.
assert.True(t, actions_service.SkipPullRequestEvent(git.DefaultContext, webhook_module.HookEventPullRequestSync, baseRepo.ID, addFileToForkedResp.Commit.SHA))
@ -162,7 +163,7 @@ func TestPullRequestTargetEvent(t *testing.T) {
Committer: time.Now(),
},
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, addFileToForkedResp)
// create Pull
@ -183,7 +184,7 @@ func TestPullRequestTargetEvent(t *testing.T) {
Type: issues_model.PullRequestGitea,
}
err = pull_service.NewPullRequest(git.DefaultContext, baseRepo, pullIssue, nil, nil, pullRequest, nil)
assert.NoError(t, err)
require.NoError(t, err)
// the new pull request cannot trigger actions, so there is still only 1 record
assert.Equal(t, 1, unittest.GetCount(t, &actions_model.ActionRun{RepoID: baseRepo.ID}))
@ -236,7 +237,7 @@ func TestSkipCI(t *testing.T) {
Committer: time.Now(),
},
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, addFileResp)
// the commit message contains a configured skip-ci string, so there is still only 1 record
@ -267,7 +268,7 @@ func TestSkipCI(t *testing.T) {
Committer: time.Now(),
},
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, addFileToBranchResp)
resp := testPullCreate(t, session, "user2", "skip-ci", true, "main", "test-skip-ci", "[skip ci] test-skip-ci")
@ -296,7 +297,7 @@ func TestCreateDeleteRefEvent(t *testing.T) {
DefaultBranch: "main",
IsPrivate: false,
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, repo)
// enable actions
@ -304,7 +305,7 @@ func TestCreateDeleteRefEvent(t *testing.T) {
RepoID: repo.ID,
Type: unit_model.TypeActions,
}}, nil)
assert.NoError(t, err)
require.NoError(t, err)
// add workflow file to the repo
addWorkflowToBaseResp, err := files_service.ChangeRepoFiles(git.DefaultContext, repo, user2, &files_service.ChangeRepoFilesOptions{
@ -331,19 +332,19 @@ func TestCreateDeleteRefEvent(t *testing.T) {
Committer: time.Now(),
},
})
assert.NoError(t, err)
require.NoError(t, err)
assert.NotEmpty(t, addWorkflowToBaseResp)
// Get the commit ID of the default branch
gitRepo, err := gitrepo.OpenRepository(git.DefaultContext, repo)
assert.NoError(t, err)
require.NoError(t, err)
defer gitRepo.Close()
branch, err := git_model.GetBranch(db.DefaultContext, repo.ID, repo.DefaultBranch)
assert.NoError(t, err)
require.NoError(t, err)
// create a branch
err = repo_service.CreateNewBranchFromCommit(db.DefaultContext, user2, repo, gitRepo, branch.CommitID, "test-create-branch")
assert.NoError(t, err)
require.NoError(t, err)
run := unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{
Title: "add workflow",
RepoID: repo.ID,
@ -356,7 +357,7 @@ func TestCreateDeleteRefEvent(t *testing.T) {
// create a tag
err = release_service.CreateNewTag(db.DefaultContext, user2, repo, branch.CommitID, "test-create-tag", "test create tag event")
assert.NoError(t, err)
require.NoError(t, err)
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{
Title: "add workflow",
RepoID: repo.ID,
@ -369,7 +370,7 @@ func TestCreateDeleteRefEvent(t *testing.T) {
// delete the branch
err = repo_service.DeleteBranch(db.DefaultContext, user2, repo, gitRepo, "test-create-branch")
assert.NoError(t, err)
require.NoError(t, err)
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{
Title: "add workflow",
RepoID: repo.ID,
@ -382,9 +383,9 @@ func TestCreateDeleteRefEvent(t *testing.T) {
// delete the tag
tag, err := repo_model.GetRelease(db.DefaultContext, repo.ID, "test-create-tag")
assert.NoError(t, err)
require.NoError(t, err)
err = release_service.DeleteReleaseByID(db.DefaultContext, repo, tag, user2, true)
assert.NoError(t, err)
require.NoError(t, err)
run = unittest.AssertExistsAndLoadBean(t, &actions_model.ActionRun{
Title: "add workflow",
RepoID: repo.ID,
@ -423,11 +424,11 @@ func TestWorkflowDispatchEvent(t *testing.T) {
defer f()
gitRepo, err := gitrepo.OpenRepository(db.DefaultContext, repo)
assert.NoError(t, err)
require.NoError(t, err)
defer gitRepo.Close()
workflow, err := actions_service.GetWorkflowFromCommit(gitRepo, "main", "dispatch.yml")
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, "refs/heads/main", workflow.Ref)
assert.Equal(t, sha, workflow.Commit.ID.String())
@ -436,7 +437,7 @@ func TestWorkflowDispatchEvent(t *testing.T) {
}
err = workflow.Dispatch(db.DefaultContext, inputGetter, repo, user2)
assert.NoError(t, err)
require.NoError(t, err)
assert.Equal(t, 1, unittest.GetCount(t, &actions_model.ActionRun{RepoID: repo.ID}))
})