bjoernager/forgejo
bjoernager/forgejo
1
Fork 0
Code Activity

Make the 500 page load themes (#24953)

Browse source 
The 500 page was not loading theme CSS, so always appeared in light
theme. This extracts the stylesheets into a shared template used by all
pages.

<img width="1262" alt="image"
src="72222b8d-a523-40d0-aa91-b9db32e5625d">

Small related rant: I think there should only be one `<head>` in all of
the templates, but I see it was deliberatly done that the 500 page has
its own `<head>` because "it should only depend the minimal template
functions", but I disagree because we are missing a lot of things that
are in the regular `<head>`.
This commit is contained in:
silverwind 2023-05-27 12:06:08 +02:00 • committed by GitHub
parent 7de46b0749
commit 4a58a8ca31
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
templates/status/500.tmpl
View file

@ -11,7 +11,7 @@
<title>Internal Server Error - {{AppName}}</title>
<link rel="icon" href="{{AssetUrlPrefix}}/img/favicon.svg" type="image/svg+xml">
<link rel="alternate icon" href="{{AssetUrlPrefix}}/img/favicon.png" type="image/png">
<link rel="stylesheet" href="{{AssetUrlPrefix}}/css/index.css?v={{AssetVersion}}">
{{template "base/stylesheets" .}}
</head>
<body>
<div class="full height">