bjoernager/forgejo
bjoernager/forgejo
1
Fork 0
Code Activity

UpdateIssueUsersByMentions was calling database write operations while (#443)

Browse source 
a transaction session was in progress. MailParticipants was failing
silently because of the SQLITE_LOCKED error. Make sure failures in
MailParticipants enter the log, and pass on the transaction context.

issue: let caller pass in database context, and use it
issue_comment: obtain database context to pass to UpdateIssueMentions
issue_comment: log any error from call to MailParticipants
issue_mail: pass on database context to UpdateIssueMentions
This commit is contained in:
Lunny Xiao 2016-12-22 17:00:39 +08:00 • committed by GitHub
parent 4c89a9c33c
commit 0c5c34d7dd
3 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
models/issue_mail.go
View file

@ -69,7 +69,7 @@ func mailIssueCommentToParticipants(issue *Issue, doer *User, mentions []string)
// and mentioned people.
func (issue *Issue) MailParticipants() (err error) {
mentions := markdown.FindAllMentions(issue.Content)
if err = UpdateIssueMentions(issue.ID, mentions); err != nil {
if err = UpdateIssueMentions(x, issue.ID, mentions); err != nil {
return fmt.Errorf("UpdateIssueMentions [%d]: %v", issue.ID, err)
}