bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

const-eval: allow calling functions with targat features disabled at compile time in WASM

Browse source 
This is not unsafe on WASM, see https://github.com/rust-lang/rust/pull/84988
This commit is contained in:
Eduardo Sánchez Muñoz 2023-10-09 19:11:42 +02:00
parent be581d9f82
commit f9b1af6587
4 changed files with 33 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
compiler/rustc_const_eval/src/interpret/terminator.rs
View file

@ -890,11 +890,13 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
}
fn check_fn_target_features(&self, instance: ty::Instance<'tcx>) -> InterpResult<'tcx, ()> {
// Calling functions with `#[target_feature]` is not unsafe on WASM, see #84988
let attrs = self.tcx.codegen_fn_attrs(instance.def_id());
if attrs
.target_features
.iter()
.any(|feature| !self.tcx.sess.target_features.contains(feature))
if !self.tcx.sess.target.is_like_wasm
&& attrs
.target_features
.iter()
.any(|feature| !self.tcx.sess.target_features.contains(feature))
{
throw_ub_custom!(
fluent::const_eval_unavailable_target_features_for_fn,