From f4bc9e6d57c1e005c6539db59762e4030bd7bd2f Mon Sep 17 00:00:00 2001
From: Andrew Paseltiner <apaseltiner@gmail.com>
Date: Mon, 7 Jan 2013 14:39:45 -0500
Subject: [PATCH] fmt: simplify parse_flags

---
 src/libcore/extfmt.rs | 39 ++++++++++++++++-----------------------
 1 file changed, 16 insertions(+), 23 deletions(-)

diff --git a/src/libcore/extfmt.rs b/src/libcore/extfmt.rs
index 3cc7e2458b2..25e349f0dc3 100644
--- a/src/libcore/extfmt.rs
+++ b/src/libcore/extfmt.rs
@@ -243,31 +243,24 @@ pub mod ct {
     }
     pub fn parse_flags(s: &str, i: uint, lim: uint) ->
        Parsed<~[Flag]> {
-        let noflags: ~[Flag] = ~[];
-        if i >= lim { return Parsed::new(move noflags, i); }
+        let mut i = i;
+        let mut flags = ~[];
 
-        fn more(f: Flag, s: &str, i: uint, lim: uint) ->
-           Parsed<~[Flag]> {
-            let next = parse_flags(s, i + 1u, lim);
-            let rest = copy next.val;
-            let j = next.next;
-            let curr: ~[Flag] = ~[f];
-            return Parsed::new(vec::append(move curr, rest), j);
+        while i < lim {
+            let f = match s[i] {
+                '-' as u8 => FlagLeftJustify,
+                '0' as u8 => FlagLeftZeroPad,
+                ' ' as u8 => FlagSpaceForSign,
+                '+' as u8 => FlagSignAlways,
+                '#' as u8 => FlagAlternate,
+                _ => break
+            };
+
+            flags.push(f);
+            i += 1;
         }
-        // Unfortunate, but because s is borrowed, can't use a closure
-     //   fn more(f: Flag, s: &str) { more_(f, s, i, lim); }
-        let f = s[i];
-        return if f == '-' as u8 {
-                more(FlagLeftJustify, s, i, lim)
-            } else if f == '0' as u8 {
-                more(FlagLeftZeroPad, s, i, lim)
-            } else if f == ' ' as u8 {
-                more(FlagSpaceForSign, s, i, lim)
-            } else if f == '+' as u8 {
-                more(FlagSignAlways, s, i, lim)
-            } else if f == '#' as u8 {
-                more(FlagAlternate, s, i, lim)
-            } else { Parsed::new(move noflags, i) };
+
+        Parsed::new(flags, i)
     }
         pub fn parse_count(s: &str, i: uint, lim: uint)
         -> Parsed<Count> {