From e04f582e567e1519a2c6909453b33ebc1497750a Mon Sep 17 00:00:00 2001 From: lcnr Date: Mon, 14 Aug 2023 15:27:14 +0200 Subject: [PATCH] review --- .../src/region_infer/opaque_types.rs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/compiler/rustc_borrowck/src/region_infer/opaque_types.rs b/compiler/rustc_borrowck/src/region_infer/opaque_types.rs index ff3883240e2..4da7b602571 100644 --- a/compiler/rustc_borrowck/src/region_infer/opaque_types.rs +++ b/compiler/rustc_borrowck/src/region_infer/opaque_types.rs @@ -385,16 +385,13 @@ fn check_opaque_type_parameter_valid( let arg_is_param = match arg.unpack() { GenericArgKind::Type(ty) => matches!(ty.kind(), ty::Param(_)), - GenericArgKind::Lifetime(lt) => { - if is_ty_alias { - matches!(*lt, ty::ReEarlyBound(_) | ty::ReFree(_)) - } else { - // FIXME(#113916): we can't currently check for unique lifetime params, - // see that issue for more. We will also have to ignore bivariant lifetime - // params for RPIT, but that's comparatively trivial ✨ - continue; - } + GenericArgKind::Lifetime(lt) if is_ty_alias => { + matches!(*lt, ty::ReEarlyBound(_) | ty::ReFree(_)) } + // FIXME(#113916): we can't currently check for unique lifetime params, + // see that issue for more. We will also have to ignore unused lifetime + // params for RPIT, but that's comparatively trivial ✨ + GenericArgKind::Lifetime(_) => continue, GenericArgKind::Const(ct) => matches!(ct.kind(), ty::ConstKind::Param(_)), };