diff --git a/compiler/rustc_driver_impl/src/lib.rs b/compiler/rustc_driver_impl/src/lib.rs index 4ad7b9f6cd1..7cded5507cb 100644 --- a/compiler/rustc_driver_impl/src/lib.rs +++ b/compiler/rustc_driver_impl/src/lib.rs @@ -482,7 +482,7 @@ fn run_compiler( if let Some(linker) = linker { let _timer = sess.timer("link"); - linker.link()? + linker.link(sess)? } if sess.opts.unstable_opts.print_fuel.is_some() { diff --git a/compiler/rustc_interface/src/interface.rs b/compiler/rustc_interface/src/interface.rs index d113e038966..e054d0a8f0b 100644 --- a/compiler/rustc_interface/src/interface.rs +++ b/compiler/rustc_interface/src/interface.rs @@ -38,13 +38,13 @@ pub type Result = result::Result; /// Can be used to run `rustc_interface` queries. /// Created by passing [`Config`] to [`run_compiler`]. pub struct Compiler { - pub(crate) sess: Lrc, + pub(crate) sess: Session, codegen_backend: Lrc, pub(crate) override_queries: Option, } impl Compiler { - pub fn session(&self) -> &Lrc { + pub fn session(&self) -> &Session { &self.sess } pub fn codegen_backend(&self) -> &Lrc { @@ -492,7 +492,7 @@ pub fn run_compiler(config: Config, f: impl FnOnce(&Compiler) -> R + Se sess.lint_store = Some(Lrc::new(lint_store)); let compiler = Compiler { - sess: Lrc::new(sess), + sess, codegen_backend: Lrc::from(codegen_backend), override_queries: config.override_queries, }; diff --git a/compiler/rustc_interface/src/queries.rs b/compiler/rustc_interface/src/queries.rs index c30ff6c4831..8345753c2e9 100644 --- a/compiler/rustc_interface/src/queries.rs +++ b/compiler/rustc_interface/src/queries.rs @@ -101,9 +101,10 @@ impl<'tcx> Queries<'tcx> { } } - fn session(&self) -> &Lrc { + fn session(&self) -> &Session { &self.compiler.sess } + fn codegen_backend(&self) -> &Lrc { self.compiler.codegen_backend() } @@ -238,7 +239,6 @@ impl<'tcx> Queries<'tcx> { pub fn linker(&'tcx self, ongoing_codegen: Box) -> Result { self.global_ctxt()?.enter(|tcx| { Ok(Linker { - sess: self.session().clone(), codegen_backend: self.codegen_backend().clone(), dep_graph: tcx.dep_graph.clone(), prepare_outputs: tcx.output_filenames(()).clone(), @@ -255,7 +255,6 @@ impl<'tcx> Queries<'tcx> { pub struct Linker { // compilation inputs - sess: Lrc, codegen_backend: Lrc, // compilation outputs @@ -267,30 +266,25 @@ pub struct Linker { } impl Linker { - pub fn link(self) -> Result<()> { - let (codegen_results, work_products) = self.codegen_backend.join_codegen( - self.ongoing_codegen, - &self.sess, - &self.prepare_outputs, - )?; + pub fn link(self, sess: &Session) -> Result<()> { + let (codegen_results, work_products) = + self.codegen_backend.join_codegen(self.ongoing_codegen, sess, &self.prepare_outputs)?; - self.sess.compile_status()?; + sess.compile_status()?; - let sess = &self.sess; let dep_graph = self.dep_graph; sess.time("serialize_work_products", || { rustc_incremental::save_work_product_index(sess, &dep_graph, work_products) }); - let prof = self.sess.prof.clone(); + let prof = sess.prof.clone(); prof.generic_activity("drop_dep_graph").run(move || drop(dep_graph)); // Now that we won't touch anything in the incremental compilation directory // any more, we can finalize it (which involves renaming it) - rustc_incremental::finalize_session_directory(&self.sess, self.crate_hash); + rustc_incremental::finalize_session_directory(sess, self.crate_hash); - if !self - .sess + if !sess .opts .output_types .keys() @@ -307,7 +301,7 @@ impl Linker { } let _timer = sess.prof.verbose_generic_activity("link_crate"); - self.codegen_backend.link(&self.sess, codegen_results, &self.prepare_outputs) + self.codegen_backend.link(sess, codegen_results, &self.prepare_outputs) } } diff --git a/tests/run-make-fulldeps/issue-19371/foo.rs b/tests/run-make-fulldeps/issue-19371/foo.rs index 1a94649163b..8fdf4c88f1f 100644 --- a/tests/run-make-fulldeps/issue-19371/foo.rs +++ b/tests/run-make-fulldeps/issue-19371/foo.rs @@ -72,6 +72,6 @@ fn compile(code: String, output: PathBuf, sysroot: PathBuf) { let ongoing_codegen = queries.ongoing_codegen()?; queries.linker(ongoing_codegen) }); - linker.unwrap().link().unwrap(); + linker.unwrap().link(compiler.session()).unwrap(); }); }