bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

tidy: add new exceptions and remove std from skip list

Browse source 
Also doing fmt inplace as requested.
This commit is contained in:
Lzu Tao 2020-08-27 13:36:02 +00:00
parent 022e1fe235
commit db6cbfc49c
2 changed files with 14 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/tools/tidy/src/pal.rs
View file

@ -56,9 +56,14 @@ const EXCEPTION_PATHS: &[&str] = &[
// Integration test for platform-specific run-time feature detection: // Integration test for platform-specific run-time feature detection:
"library/std/tests/run-time-detect.rs", "library/std/tests/run-time-detect.rs",
"library/std/src/net/test.rs", "library/std/src/net/test.rs",
"library/std/src/net/addr",
"library/std/src/net/udp",
"library/std/src/sys_common/mod.rs", "library/std/src/sys_common/mod.rs",
"library/std/src/sys_common/net.rs", "library/std/src/sys_common/net.rs",
"library/std/src/sys_common/backtrace.rs", "library/std/src/sys_common/backtrace.rs",
"library/std/src/sys_common/remutex.rs",
"library/std/src/sync/mutex.rs",
"library/std/src/sync/rwlock.rs",
// panic_unwind shims // panic_unwind shims
"library/std/src/panicking.rs", "library/std/src/panicking.rs",
"library/term", // Not sure how to make this crate portable, but test crate needs it. "library/term", // Not sure how to make this crate portable, but test crate needs it.

14
src/tools/tidy/src/unit_tests.rs
View file

@ -20,15 +20,19 @@ pub fn check(root_path: &Path, bad: &mut bool) {
let mut skip = |path: &Path| { let mut skip = |path: &Path| {
let file_name = path.file_name().unwrap_or_default(); let file_name = path.file_name().unwrap_or_default();
if path.is_dir() { if path.is_dir() {
super::filter_dirs(path) || super::filter_dirs(path)
path.ends_with("src/test") || || path.ends_with("src/test")
path.ends_with("src/doc") || || path.ends_with("src/doc")
path.ends_with("library/std") || // FIXME? || (file_name == "tests" || file_name == "benches") && !is_core(path)
(file_name == "tests" || file_name == "benches") && !is_core(path)
} else { } else {
let extension = path.extension().unwrap_or_default(); let extension = path.extension().unwrap_or_default();
extension != "rs" extension != "rs"
|| (file_name == "tests.rs" || file_name == "benches.rs") && !is_core(path) || (file_name == "tests.rs" || file_name == "benches.rs") && !is_core(path)
// UI tests with different names
|| path.ends_with("src/thread/local/dynamic_tests.rs")
|| path.ends_with("src/sync/mpsc/sync_tests.rs")
// Has copyright banner
|| path.ends_with("src/sys/cloudabi/abi/cloudabi.rs")
} }
}; };