diff --git a/compiler/rustc_session/src/code_stats.rs b/compiler/rustc_session/src/code_stats.rs index aa2b1f48daf..cbb03ffd7a0 100644 --- a/compiler/rustc_session/src/code_stats.rs +++ b/compiler/rustc_session/src/code_stats.rs @@ -91,10 +91,10 @@ impl CodeStats { } }); - for info in &sorted { + for info in sorted { + let TypeSizeInfo { type_description, overall_size, align, kind, variants, .. } = info; println!( - "print-type-size type: `{}`: {} bytes, alignment: {} bytes", - info.type_description, info.overall_size, info.align + "print-type-size type: `{type_description}`: {overall_size} bytes, alignment: {align} bytes" ); let indent = " "; @@ -111,11 +111,11 @@ impl CodeStats { // to reflect the presence of the discriminant. let mut max_variant_size = discr_size; - let struct_like = match info.kind { + let struct_like = match kind { DataTypeKind::Struct | DataTypeKind::Closure => true, DataTypeKind::Enum | DataTypeKind::Union => false, }; - for (i, variant_info) in info.variants.iter().enumerate() { + for (i, variant_info) in variants.into_iter().enumerate() { let VariantInfo { ref name, kind: _, align: _, size, ref fields } = *variant_info; let indent = if !struct_like { let name = match name.as_ref() { @@ -142,8 +142,8 @@ impl CodeStats { let mut fields = fields.clone(); fields.sort_by_key(|f| (f.offset, f.size)); - for field in fields.iter() { - let FieldInfo { ref name, offset, size, align } = *field; + for field in fields { + let FieldInfo { ref name, offset, size, align } = field; if offset > min_offset { let pad = offset - min_offset; @@ -171,18 +171,10 @@ impl CodeStats { } } - assert!( - max_variant_size <= info.overall_size, - "max_variant_size {} !<= {} overall_size", - max_variant_size, - info.overall_size - ); - if max_variant_size < info.overall_size { - println!( - "print-type-size {}end padding: {} bytes", - indent, - info.overall_size - max_variant_size - ); + match overall_size.checked_sub(max_variant_size) { + None => panic!("max_variant_size {max_variant_size} > {overall_size} overall_size"), + Some(diff @ 1..) => println!("print-type-size {indent}end padding: {diff} bytes"), + Some(0) => {} } } }