From b73f1a51dcd1011129dc5c5c55a7577134410dbc Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Mon, 16 Sep 2019 13:08:21 +0200 Subject: [PATCH] better and more consistent variable names --- src/librustc_mir/interpret/operand.rs | 16 ++++++++-------- src/librustc_mir/interpret/place.rs | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/librustc_mir/interpret/operand.rs b/src/librustc_mir/interpret/operand.rs index 3b07202f898..2a0bad2fa74 100644 --- a/src/librustc_mir/interpret/operand.rs +++ b/src/librustc_mir/interpret/operand.rs @@ -698,28 +698,28 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> { // We need to use machine arithmetic. let niche_start_val = ImmTy::from_uint(niche_start, discr_layout); let variants_start_val = ImmTy::from_uint(variants_start, discr_layout); - let adjusted_discr = self.binary_op( + let variant_index_relative_val = self.binary_op( mir::BinOp::Sub, discr_val, niche_start_val, )?; - let adjusted_discr = self.binary_op( + let variant_index_val = self.binary_op( mir::BinOp::Add, - adjusted_discr, + variant_index_relative_val, variants_start_val, )?; - let adjusted_discr = adjusted_discr + let variant_index = variant_index_val .to_scalar()? .assert_bits(discr_val.layout.size); // Check if this is in the range that indicates an actual discriminant. - if variants_start <= adjusted_discr && adjusted_discr <= variants_end { - let index = adjusted_discr as usize; - assert_eq!(index as u128, adjusted_discr); + if variants_start <= variant_index && variant_index <= variants_end { + let index = variant_index as usize; + assert_eq!(index as u128, variant_index); assert!(index < rval.layout.ty .ty_adt_def() .expect("tagged layout for non adt") .variants.len()); - (adjusted_discr, VariantIdx::from_usize(index)) + (variant_index, VariantIdx::from_usize(index)) } else { (dataful_variant.as_u32() as u128, dataful_variant) } diff --git a/src/librustc_mir/interpret/place.rs b/src/librustc_mir/interpret/place.rs index 0a23c1222b4..636b070a3d8 100644 --- a/src/librustc_mir/interpret/place.rs +++ b/src/librustc_mir/interpret/place.rs @@ -1073,19 +1073,19 @@ where let variants_start_val = ImmTy::from_uint(variants_start, discr_layout); let niche_start_val = ImmTy::from_uint(niche_start, discr_layout); let variant_index_val = ImmTy::from_uint(variant_index.as_u32(), discr_layout); - let niche_val = self.binary_op( + let variant_index_relative_val = self.binary_op( mir::BinOp::Sub, variant_index_val, variants_start_val, )?; - let niche_val = self.binary_op( + let discr_val = self.binary_op( mir::BinOp::Add, - niche_val, + variant_index_relative_val, niche_start_val, )?; // Write result. let niche_dest = self.place_field(dest, discr_index as u64)?; - self.write_immediate(*niche_val, niche_dest)?; + self.write_immediate(*discr_val, niche_dest)?; } } }