From ae7fca1e1f5d74bf88ffacaf339b28d8c73f8c4f Mon Sep 17 00:00:00 2001 From: mitaa Date: Wed, 9 Mar 2016 02:05:39 +0100 Subject: [PATCH] Check for `doc(inline)` instead of `.*(inline)` --- src/librustdoc/visit_ast.rs | 4 +-- .../rustdoc/inline_local/please_inline.rs | 29 +++++++++++++++++++ 2 files changed, 31 insertions(+), 2 deletions(-) create mode 100644 src/test/rustdoc/inline_local/please_inline.rs diff --git a/src/librustdoc/visit_ast.rs b/src/librustdoc/visit_ast.rs index bc6b4f83984..7a3adc157c2 100644 --- a/src/librustdoc/visit_ast.rs +++ b/src/librustdoc/visit_ast.rs @@ -276,10 +276,10 @@ impl<'a, 'tcx> RustdocVisitor<'a, 'tcx> { let node = if item.vis == hir::Public { let please_inline = item.attrs.iter().any(|item| { match item.meta_item_list() { - Some(list) => { + Some(list) if &item.name()[..] == "doc" => { list.iter().any(|i| &i.name()[..] == "inline") } - None => false, + _ => false, } }); match self.visit_view_path(node, om, item.id, please_inline) { diff --git a/src/test/rustdoc/inline_local/please_inline.rs b/src/test/rustdoc/inline_local/please_inline.rs new file mode 100644 index 00000000000..d237ab8dab0 --- /dev/null +++ b/src/test/rustdoc/inline_local/please_inline.rs @@ -0,0 +1,29 @@ +// Copyright 2016 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +pub mod foo { + pub struct Foo; +} + +// @has please_inline/a/index.html +pub mod a { + // @!has - 'pub use foo::' + // @has please_inline/a/struct.Foo.html + #[doc(inline)] + pub use foo::Foo; +} + +// @has please_inline/b/index.html +pub mod b { + // @has - 'pub use foo::' + // @!has please_inline/b/struct.Foo.html + #[feature(inline)] + pub use foo::Foo; +}