bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Fix dropping_copy_types lint from linting in match-arm with side-effects

Browse source
This commit is contained in:
Urgau 2023-07-01 16:05:55 +02:00
parent e69c7306e2
commit 908574b5e7
3 changed files with 39 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
compiler/rustc_lint/src/drop_forget_useless.rs
View file

@ -194,7 +194,7 @@ fn is_single_call_in_arm<'tcx>(
arg: &'tcx Expr<'_>,
drop_expr: &'tcx Expr<'_>,
) -> bool {
if matches!(arg.kind, ExprKind::Call(..) | ExprKind::MethodCall(..)) {
if arg.can_have_side_effects() {
let parent_node = cx.tcx.hir().find_parent(drop_expr.hir_id);
if let Some(Node::Arm(Arm { body, .. })) = &parent_node {
return body.hir_id == drop_expr.hir_id;