From 5caa7f9a4a2455e82da9bf1171937f024e9e026c Mon Sep 17 00:00:00 2001 From: Lukas Bergdoll Date: Thu, 20 Jun 2024 18:03:42 +0200 Subject: [PATCH] Improve html-checker error message The previous message omits which of the dozens of tools called tidy is meant. And it's written in a way that one can easily miss the *not*, thinking it reads "Note that `tidy` is the in-tree `src/tools/tidy` but needs to be installed". The error message should hopefully help future contributors. --- src/bootstrap/src/core/build_steps/test.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootstrap/src/core/build_steps/test.rs b/src/bootstrap/src/core/build_steps/test.rs index 360bd3840d4..8b65085e14e 100644 --- a/src/bootstrap/src/core/build_steps/test.rs +++ b/src/bootstrap/src/core/build_steps/test.rs @@ -201,7 +201,7 @@ impl Step for HtmlCheck { if !check_if_tidy_is_installed() { eprintln!("not running HTML-check tool because `tidy` is missing"); eprintln!( - "Note that `tidy` is not the in-tree `src/tools/tidy` but needs to be installed" + "You need the HTML tidy tool https://www.html-tidy.org/, this tool is *not* part of the rust project and needs to be installed separately, for example via your package manager." ); panic!("Cannot run html-check tests"); }