From 56ba8feed694f46f28d9e65e132e1b62cc18e0b4 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Fri, 23 Oct 2015 20:35:44 -0700 Subject: [PATCH] Update libsyntax tests. --- src/libsyntax/parse/mod.rs | 4 ++-- src/libsyntax/util/parser_testing.rs | 24 +++++++++++------------- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/src/libsyntax/parse/mod.rs b/src/libsyntax/parse/mod.rs index 15625cba65c..a468f0d1d98 100644 --- a/src/libsyntax/parse/mod.rs +++ b/src/libsyntax/parse/mod.rs @@ -856,7 +856,7 @@ mod tests { #[test] fn parse_stmt_1 () { assert!(string_to_stmt("b;".to_string()) == - P(Spanned{ + Some(P(Spanned{ node: ast::StmtExpr(P(ast::Expr { id: ast::DUMMY_NODE_ID, node: ast::ExprPath(None, ast::Path { @@ -871,7 +871,7 @@ mod tests { }), span: sp(0,1)}), ast::DUMMY_NODE_ID), - span: sp(0,1)})) + span: sp(0,1)}))) } diff --git a/src/libsyntax/util/parser_testing.rs b/src/libsyntax/util/parser_testing.rs index 6e6e2d181b9..57138bf26ee 100644 --- a/src/libsyntax/util/parser_testing.rs +++ b/src/libsyntax/util/parser_testing.rs @@ -9,7 +9,7 @@ // except according to those terms. use ast; -use parse::{ParseSess,filemap_to_tts}; +use parse::{ParseSess,PResult,filemap_to_tts}; use parse::new_parser_from_source_str; use parse::parser::Parser; use parse::token; @@ -31,11 +31,11 @@ pub fn string_to_parser<'a>(ps: &'a ParseSess, source_str: String) -> Parser<'a> } fn with_error_checking_parse(s: String, f: F) -> T where - F: FnOnce(&mut Parser) -> T, + F: FnOnce(&mut Parser) -> PResult, { let ps = ParseSess::new(); let mut p = string_to_parser(&ps, s); - let x = f(&mut p); + let x = panictry!(f(&mut p)); p.abort_if_errors(); x } @@ -43,39 +43,37 @@ fn with_error_checking_parse(s: String, f: F) -> T where /// Parse a string, return a crate. pub fn string_to_crate (source_str : String) -> ast::Crate { with_error_checking_parse(source_str, |p| { - panictry!(p.parse_crate_mod()) + p.parse_crate_mod() }) } /// Parse a string, return an expr pub fn string_to_expr (source_str : String) -> P { with_error_checking_parse(source_str, |p| { - p.parse_expr() + p.parse_expr_nopanic() }) } /// Parse a string, return an item pub fn string_to_item (source_str : String) -> Option> { with_error_checking_parse(source_str, |p| { - p.parse_item() + p.parse_item_nopanic() }) } /// Parse a string, return a stmt -pub fn string_to_stmt(source_str : String) -> P { +pub fn string_to_stmt(source_str : String) -> Option> { with_error_checking_parse(source_str, |p| { - p.parse_stmt().unwrap() + p.parse_stmt_nopanic() }) } /// Parse a string, return a pat. Uses "irrefutable"... which doesn't /// (currently) affect parsing. pub fn string_to_pat(source_str: String) -> P { - // Binding `sess` and `parser` works around dropck-injected - // region-inference issues; see #25212, #22323, #22321. - let sess = ParseSess::new(); - let mut parser = string_to_parser(&sess, source_str); - parser.parse_pat() + with_error_checking_parse(source_str, |p| { + p.parse_pat_nopanic() + }) } /// Convert a vector of strings to a vector of ast::Ident's