From 53abb5edbd2079fdcc1c2887cf0a89aad75d6ea1 Mon Sep 17 00:00:00 2001
From: Niko Matsakis <niko@alum.mit.edu>
Date: Wed, 19 Sep 2012 06:56:29 -0700
Subject: [PATCH] use && for fn() even in legacy mode to work around mem leak

---
 src/rustc/middle/ty.rs | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/rustc/middle/ty.rs b/src/rustc/middle/ty.rs
index 7932474a698..78a5485ebae 100644
--- a/src/rustc/middle/ty.rs
+++ b/src/rustc/middle/ty.rs
@@ -1090,12 +1090,22 @@ pure fn mach_sty(cfg: @session::config, t: t) -> sty {
 }
 
 fn default_arg_mode_for_ty(tcx: ctxt, ty: ty::t) -> ast::rmode {
-    if ty::type_is_immediate(ty) {
+    return if ty::type_is_immediate(ty) {
         ast::by_val
-    } else if tcx.legacy_modes {
+    } else if tcx.legacy_modes || type_is_fn(ty) {
+        //                        ^^^^^^^^^^^^^^
+        // FIXME(#2202) --- We retain by-ref by default to workaround a memory
+        // leak that otherwise results when @fn is upcast to &fn.
         ast::by_ref
     } else {
         ast::by_copy
+    };
+
+    fn type_is_fn(ty: t) -> bool {
+        match get(ty).sty {
+            ty_fn(*) => true,
+            _ => false
+        }
     }
 }