diff --git a/compiler/rustc_resolve/src/late/diagnostics.rs b/compiler/rustc_resolve/src/late/diagnostics.rs index a4bf19aab95..28d636ef1b2 100644 --- a/compiler/rustc_resolve/src/late/diagnostics.rs +++ b/compiler/rustc_resolve/src/late/diagnostics.rs @@ -6,7 +6,10 @@ use crate::{CrateLint, Module, ModuleKind, ModuleOrUniformRoot}; use crate::{PathResult, PathSource, Segment}; use rustc_ast::visit::FnKind; -use rustc_ast::{self as ast, Expr, ExprKind, Item, ItemKind, NodeId, Path, Ty, TyKind}; +use rustc_ast::{ + self as ast, Expr, ExprKind, GenericParam, GenericParamKind, Item, ItemKind, NodeId, Path, Ty, + TyKind, +}; use rustc_ast_pretty::pprust::path_segment_to_string; use rustc_data_structures::fx::FxHashSet; use rustc_errors::{pluralize, struct_span_err, Applicability, DiagnosticBuilder}; @@ -1635,6 +1638,10 @@ impl<'a: 'ast, 'ast> LateResolutionVisitor<'a, '_, 'ast> { let (span, sugg) = if let [.., param] = &generics.params[..] { let span = if let [.., bound] = ¶m.bounds[..] { bound.span() + } else if let GenericParam { + kind: GenericParamKind::Const { ty, kw_span: _, default }, .. + } = param { + default.as_ref().map(|def| def.value.span).unwrap_or(ty.span) } else { param.ident.span }; diff --git a/src/test/ui/const-generics/diagnostics.stderr b/src/test/ui/const-generics/diagnostics.stderr index 983cb52f3ff..2e3132c2eb7 100644 --- a/src/test/ui/const-generics/diagnostics.stderr +++ b/src/test/ui/const-generics/diagnostics.stderr @@ -31,8 +31,8 @@ LL | impl Foo for C {} | ^ help: you might be missing a type parameter | -LL | impl Foo for C {} - | ^^^ +LL | impl Foo for C {} + | ^^^ error[E0747]: unresolved item provided when a constant was expected --> $DIR/diagnostics.rs:7:16 diff --git a/src/test/ui/missing/missing-items/missing-type-parameter2.rs b/src/test/ui/missing/missing-items/missing-type-parameter2.rs index e5d90bb6ff0..15dc5ef797b 100644 --- a/src/test/ui/missing/missing-items/missing-type-parameter2.rs +++ b/src/test/ui/missing/missing-items/missing-type-parameter2.rs @@ -11,7 +11,11 @@ impl X {} //~| ERROR defaults for const parameters are only allowed in `struct`, `enum`, `type`, or `trait` definitions //~| ERROR unresolved item provided when a constant was expected -fn bar(a: A) {} +fn foo(_: T) where T: Send {} +//~^ ERROR cannot find type `T` in this scope +//~| ERROR cannot find type `T` in this scope + +fn bar(_: A) {} //~^ ERROR cannot find type `A` in this scope fn main() { diff --git a/src/test/ui/missing/missing-items/missing-type-parameter2.stderr b/src/test/ui/missing/missing-items/missing-type-parameter2.stderr index 545be1c34fb..985a9bb2a3f 100644 --- a/src/test/ui/missing/missing-items/missing-type-parameter2.stderr +++ b/src/test/ui/missing/missing-items/missing-type-parameter2.stderr @@ -30,26 +30,62 @@ LL | impl X {} | ^ help: you might be missing a type parameter | -LL | impl X {} - | ^^^ +LL | impl X {} + | ^^^ -error[E0412]: cannot find type `A` in this scope - --> $DIR/missing-type-parameter2.rs:14:24 +error[E0412]: cannot find type `T` in this scope + --> $DIR/missing-type-parameter2.rs:14:20 | LL | struct X(); | ------------------------ similarly named struct `X` defined here ... -LL | fn bar(a: A) {} +LL | fn foo(_: T) where T: Send {} + | ^ + | +help: a struct with a similar name exists + | +LL | fn foo(_: T) where X: Send {} + | ^ +help: you might be missing a type parameter + | +LL | fn foo(_: T) where T: Send {} + | ^^^ + +error[E0412]: cannot find type `T` in this scope + --> $DIR/missing-type-parameter2.rs:14:11 + | +LL | struct X(); + | ------------------------ similarly named struct `X` defined here +... +LL | fn foo(_: T) where T: Send {} + | ^ + | +help: a struct with a similar name exists + | +LL | fn foo(_: X) where T: Send {} + | ^ +help: you might be missing a type parameter + | +LL | fn foo(_: T) where T: Send {} + | ^^^ + +error[E0412]: cannot find type `A` in this scope + --> $DIR/missing-type-parameter2.rs:18:24 + | +LL | struct X(); + | ------------------------ similarly named struct `X` defined here +... +LL | fn bar(_: A) {} | ^ | help: a struct with a similar name exists | -LL | fn bar(a: X) {} +LL | fn bar(_: X) {} | ^ help: you might be missing a type parameter | -LL | fn bar(a: A) {} - | ^^^ +LL | fn bar(_: A) {} + | ^^^ error[E0747]: unresolved item provided when a constant was expected --> $DIR/missing-type-parameter2.rs:6:8 @@ -79,7 +115,7 @@ help: if this generic argument was intended as a const parameter, surround it wi LL | impl X<{ N }> {} | ^ ^ -error: aborting due to 6 previous errors +error: aborting due to 8 previous errors Some errors have detailed explanations: E0412, E0747. For more information about an error, try `rustc --explain E0412`.