bjoernager/rust
bjoernager/rust
1
Fork 0
Code Activity

Use nicer spans for deref_into_dyn_supertrait

Browse source
This commit is contained in:
Maybe Waffle 2022-11-23 16:12:51 +00:00
parent 0d4a5c725a
commit 20f3de5ab1
3 changed files with 17 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
compiler/rustc_lint/src/deref_into_dyn_supertrait.rs
View file

@ -3,6 +3,7 @@ use crate::{LateContext, LateLintPass, LintContext};
use rustc_errors::DelayDm;
use rustc_hir as hir;
use rustc_middle::{traits::util::supertraits, ty};
use rustc_span::sym;
declare_lint! {
/// The `deref_into_dyn_supertrait` lint is output whenever there is a use of the
@ -72,13 +73,19 @@ impl<'tcx> LateLintPass<'tcx> for DerefIntoDynSupertrait {
{
cx.struct_span_lint(
DEREF_INTO_DYN_SUPERTRAIT,
item.span,
cx.tcx.def_span(item.owner_id.def_id),
DelayDm(|| {
format!(
"`{t}` implements `Deref` with supertrait `{target_principal}` as output"
"`{t}` implements `Deref` with supertrait `{target_principal}` as target"
)
}),
|lint| lint,
|lint| {
if let Some(target_span) = impl_.items.iter().find_map(|i| (i.ident.name == sym::Target).then_some(i.span)) {
lint.span_label(target_span, "target type is set here");
}
lint
},
)
}
}