From 15d6837a16d727a3d37a703eaedf48e62c260290 Mon Sep 17 00:00:00 2001 From: William Throwe Date: Sun, 23 Aug 2015 21:46:10 -0400 Subject: [PATCH] Mark main-like functions allow(dead_code) in tests Fixes #12327. --- src/libsyntax/test.rs | 49 +++++++++++++------ src/test/compile-fail/test-warns-dead-code.rs | 17 +++++++ src/test/run-pass/test-main-not-dead-attr.rs | 18 +++++++ src/test/run-pass/test-main-not-dead.rs | 15 ++++++ 4 files changed, 84 insertions(+), 15 deletions(-) create mode 100644 src/test/compile-fail/test-warns-dead-code.rs create mode 100644 src/test/run-pass/test-main-not-dead-attr.rs create mode 100644 src/test/run-pass/test-main-not-dead.rs diff --git a/src/libsyntax/test.rs b/src/libsyntax/test.rs index 26fb287ce35..3fbcbd728aa 100644 --- a/src/libsyntax/test.rs +++ b/src/libsyntax/test.rs @@ -14,6 +14,7 @@ #![allow(unused_imports)] use self::HasTestSignature::*; +use std::iter; use std::slice; use std::mem; use std::vec; @@ -24,6 +25,7 @@ use codemap::{DUMMY_SP, Span, ExpnInfo, NameAndSpan, MacroAttribute}; use codemap; use diagnostic; use config; +use entry::{self, EntryPointType}; use ext::base::ExtCtxt; use ext::build::AstBuilder; use ext::expand::ExpansionConfig; @@ -177,22 +179,39 @@ impl<'a> fold::Folder for TestHarnessGenerator<'a> { // the one we're going to add. Only if compiling an executable. mod_folded.items = mem::replace(&mut mod_folded.items, vec![]).move_map(|item| { - item.map(|ast::Item {id, ident, attrs, node, vis, span}| { - ast::Item { - id: id, - ident: ident, - attrs: attrs.into_iter().filter_map(|attr| { - if !attr.check_name("main") { - Some(attr) - } else { - None + match entry::entry_point_type(&item, self.cx.path.len() + 1) { + EntryPointType::MainNamed | + EntryPointType::MainAttr | + EntryPointType::Start => + item.map(|ast::Item {id, ident, attrs, node, vis, span}| { + let allow_str = InternedString::new("allow"); + let dead_code_str = InternedString::new("dead_code"); + let allow_dead_code_item = + attr::mk_list_item(allow_str, + vec![attr::mk_word_item(dead_code_str)]); + let allow_dead_code = attr::mk_attr_outer(attr::mk_attr_id(), + allow_dead_code_item); + + ast::Item { + id: id, + ident: ident, + attrs: attrs.into_iter().filter_map(|attr| { + if !attr.check_name("main") { + Some(attr) + } else { + None + } + }) + .chain(iter::once(allow_dead_code)) + .collect(), + node: node, + vis: vis, + span: span } - }).collect(), - node: node, - vis: vis, - span: span - } - }) + }), + EntryPointType::None | + EntryPointType::OtherMain => item, + } }); if !tests.is_empty() || !tested_submods.is_empty() { diff --git a/src/test/compile-fail/test-warns-dead-code.rs b/src/test/compile-fail/test-warns-dead-code.rs new file mode 100644 index 00000000000..0e25f1e965a --- /dev/null +++ b/src/test/compile-fail/test-warns-dead-code.rs @@ -0,0 +1,17 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: --test + +#![deny(dead_code)] + +fn dead() {} //~ error: function is never used: `dead` + +fn main() {} diff --git a/src/test/run-pass/test-main-not-dead-attr.rs b/src/test/run-pass/test-main-not-dead-attr.rs new file mode 100644 index 00000000000..295559b6ddb --- /dev/null +++ b/src/test/run-pass/test-main-not-dead-attr.rs @@ -0,0 +1,18 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: --test + +#![feature(main)] + +#![deny(dead_code)] + +#[main] +fn foo() { panic!(); } diff --git a/src/test/run-pass/test-main-not-dead.rs b/src/test/run-pass/test-main-not-dead.rs new file mode 100644 index 00000000000..7de3ca74796 --- /dev/null +++ b/src/test/run-pass/test-main-not-dead.rs @@ -0,0 +1,15 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: --test + +#![deny(dead_code)] + +fn main() { panic!(); }